8000 Moving to NumPy 2.x by orliac · Pull Request #37 · epfl-radio-astro/bipp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Moving to NumPy 2.x #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Moving to NumPy 2.x #37

wants to merge 1 commit into from

Conversation

orliac
Copy link
Collaborator
@orliac orliac commented Dec 17, 2024

This PR to put BIPP on NumPy>2. The main changes are:

  1. pybind11 2.12+ required, see https://pybind11.readthedocs.io/en/stable/
  2. np.array(..., copy=False) calls changed to np.asarray(...), see https://numpy.org/devdocs/numpy_2_0_migration_guide.html

Without upgrading pybind11 a weird error arises about the impossibility to resize non-contiguous array here:

bipp/python/pybipp.cpp

Line 137 in cd712c1

d.resize({pev.first});

@orliac orliac requested a review from AdhocMan December 17, 2024 14:02
@orliac
Copy link
Collaborator Author
orliac commented May 12, 2025

Hi @AdhocMan,
Can you see why the cscs/default check is failing? I can't reproduce the error on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

< 3487 /form>
1 participant
@orliac
0