Inline TrackArtistLinks in Album page #633
Conversation
First implementation is a bit of a hardcode; working on making it work with all artist relations. Will then add a config flag or something for it to be user-toggleable.
For now, it's always shown. Soon, I will be implementing a setting to chose whether to show everything, remixers only, or nothing.
|
Heh, thanks for the pr, it does look quite good! |
|
What do you think of the current track artists? |
|
@defvs if you are OK, I will use your branch as a first step to implement this feature myself. |
|
Current tests: Changes:
Next step would be to centralize code to get the exact roles for performers (like in the track info panel) |
|
|
|
Nice, thanks for merging this. Sorry, I was away for the weekend. Tell me if there's anything linked I can work on. |
|
I see that you implemented a WSelectionBox which was exactly what I was working on. Seems like you were more efficient than me : ) |
|
Unfortunately, I implemented something clunky I need to rework (https://redmine.emweb.be/boards/2/topics/18850) |
|
Hey, is there anything in particular I need to do to have Performers show up inline? I have all the options selected under settings, and I know the tracks have performers when I look in mbz picard. Lyricist, composer, remixer, conductor, all show up. But performers do not. Thanks! |
|
Hello! |
I've attached a song file here. This is a screenshot of it from my computer: And the settings: Let me know if anything else is needed. Thanks! |
|
@epoupon hey, just curious if you were able to reproduce this? Thanks. |
|
Hello, indeed |
|
Thanks! |
|
Well I am not sure. |
So my tags are too old? Is there any way to make tipl tags work? Or is resaving with the newer version the only option? Also, what version of picard did you use? Thanks! |
|
For now, resaving is the only option. I could hack in lms but I think we should first report the issue on taglib |
|
Ok great. Whats the best way for me to contact them? |
|
You can open an issue here: https://github.com/taglib/taglib , provide your sample file, and tell your performers in the TIPL frame are not parsed by TagLib (but it works if resavec in a TMCL frame) |
|
I received few responses there, but I'm not sure what any of it means, unfortunately. |
|
Basically, the author suggests that taglib handles the IPLS frame of your id3v2.3 differently (the one that contains your performers), so that performers will be handled with no change on LMS side. Or you could just resave your file using id3v2.4 (you would also benefit from true multi-valued tags, no need for custom seprators) |
|
Gotcha. Thanks! Is there a suggested way to update my tags to 2.4 other than running them all again through picard? |
|
It looks like someone made a pull request and fixed the issue: < 67E6 a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3146042734" data-permission-text="Title is private" data-url="https://github.com/taglib/taglib/issues/1276" data-hovercard-type="pull_request" data-hovercard-url="/taglib/taglib/pull/1276/hovercard" href="https://github.com/taglib/taglib/pull/1276">taglib/taglib#1276 So now it's just a matter of waiting until its added to the main code? |
|
Perfect! Yes, we have to wait for a new taglib release, and if you use the lms docker image, it will be available shortly after |
|
Does "merged with taglib: master" mean it's in? You do a great job of showing the next release status with that milestone tab. They're a little more vague. |
|
It is in their master branch, so we now have to wait for their next release. |
|
Taglib has released a new update including the fix for this issue. |
|
Thanks for the notification, will do this in #700 |
Implement #626
First time using Wt, feel free to correct me, similarly feel free to correct my code styling.
Current implementation works for all
TrackArtistLinkType. It is currently hardcoded to display them all. This PR is set as draft as I will be implementing a config in the user's settings to either show only remixers (my initial goal), all relationships, or nothing.