make --tp-carrier file shell-compatible #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2021 16:08
This reworks mostly code that was already there for --tp-print and --tp-export so no the --tp-carrier option writes and reads the same format. This makes it so you can directly source the carrier file from shell scripts. Signed-off-by: Amy Tobey <atobey@equinix.com>
Rather than parsing the file it's easiest to look and see if the traceparent is there at the end of the file after removing whitespace. Signed-off-by: Amy Tobey <atobey@equinix.com>
tobert
pushed a commit
to tobert/osie
that referenced
this pull request
Sep 9, 2021
I forgot I didn't have --wait merged into v0.0.15 so I went off and got that polished off in these PRs: equinix-labs/otel-cli#73 equinix-labs/otel-cli#74 Signed-off-by: Amy Tobey <atobey@equinix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks mostly code that was already there for --tp-print and --tp-export so no the --tp-carrier option writes and reads the same format. This makes it so you can directly source the carrier file from shell scripts.