MAINT: Port forward_models to new ERT Plugin system #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
approved these changes
Sep 3, 2024
Comment on lines
30
to
31
| def validate_pre_experiment(self, fm_step_json: ForwardModelStepJSON) -> None: | ||
| return fm_step_json |
There was a problem hiding this comment.
Should be very nice to be able to pop a Pydantic model_validate in these pre-experiment validations -- once configuration files in this repository are modeled by Pydantic
7ae415b to
4aa1a7e
Compare
I know, I think it could be quite cool 👍 early validation will be such an improvement! These jobs normally come after quite some hours of simulation.. and it is a pain when they fail 😄 |
4aa1a7e to
6e2d7c9
Compare
6e2d7c9 to
aef5dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130
Mainly following work done in https://github.com/equinor/semeio