Fix rails widget rendering to work with depends_on #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizing to string until after the dependencies have been rendered
|
Hey @sublogical, i'm currently working on a fork at https://github.com/adamjacobbecker/erector-rails4. I have an email in to Alex to see what we can do re: continuing support of this project. curious if you have a second -- can you provide some more details on how to recreate this bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rails render widget code uses the view output buffer as the output buffer passed into Erector::Output. This causes the placeholder string to be copied into the output buffer as the header is rendered. This prevents the actual rendering of the dependencies from working later on in the process.
This change makes render widget use the default output buffer (an array) and then serializes it into the rails view output buffer when it's done.