8000 makeNavigationDelegate should return non-optional. by erikdrobne · Pull Request #31 · erikdrobne/SwiftUICoordinator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

makeNavigationDelegate should return non-optional. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

makeNavigationDelegate should return non-optional. #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftUICoordinator/Routing/NavigationController/NavigationControllerFactory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Foundation

@MainActor
protocol NavigationControllerCreatable {
func makeNavigationDelegate(_ transitions: [Transitionable]) -> NavigationControllerDelegateProxy?
func makeNavigationDelegate(_ transitions: [Transitionable]) -> NavigationControllerDelegateProxy
func makeNavigationController(
isNavigationBarHidden: Bool,
delegate: NavigationControllerDelegateProxy?
Expand All @@ -20,7 +20,7 @@ public final class NavigationControllerFactory: NavigationControllerCreatable {

public init() {}

public func makeNavigationDelegate(_ transitions: [Transitionable]) -> NavigationControllerDelegateProxy? {
public func makeNavigationDelegate(_ transitions: [Transitionable]) -> NavigationControllerDelegateProxy {
let transitionProvider = TransitionProvider(transitions: transitions)
let transitionHandler = NavigationControllerTransitionHandler(provider: transitionProvider)
return NavigationControllerDelegateProxy(transitionHandler: transitionHandler)
Expand Down
0