update erlydtl compiler to output to _build, add simple test #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,7 @@ process_command(State, Command) -> | |||
| %% to have both $REBAR_PROFILE set and use 'as' in a command | |||
| case rebar_state:current_profiles(State) of | |||
| [default] -> | |||
| do([{default, hd(TargetProviders)} | tl(TargetProviders)], State); | |||
| do([hd(TargetProviders) | tl(TargetProviders)], State); | |||
There was a problem hiding this comment.
If you're gonna do that, just use TargetProviders. I thought this was needed for as to be fetched as a command in the undefined namespace though!
There was a problem hiding this comment.
Hah, woops, yea. But na, it isn't needed, at least not with the v1.3.0 version of providers.
| @@ -84,7 +84,7 @@ process_command(State, Command) -> | |||
| %% to have both $REBAR_PROFILE set and use 'as' in a command | |||
| case rebar_state:current_profiles(State) of | |||
| [default] -> | |||
| do([{default, hd(TargetProviders)} | tl(TargetProviders)], State); | |||
| do(TargetProviders, State); | |||
There was a problem hiding this comment.
I think this is still needed. See without it:
→ DEBUG=1 ./rebar3 as test do help
===> Consult config file "rebar.config"
===> Consult config file "rebar.lock"
===> Uncaught error in rebar_core. Run with DEBUG=1 to see stacktrace
===> Uncaught error: {'EXIT',
{{badrecord,provider},
[{providers,do,2,
[{file,"src/providers.erl"},{line,86}]},
{rebar_core,do,2,
[{file,"src/rebar_core.erl"},
{line,129}]},
{rebar3,main,1,
[{file,"src/rebar3.erl"},{line,46}]},
{escript,run,2,
[{file,"escript.erl"},{line,752}]},
{escript,start,1,
[{file,"escript.erl"},{line,276}]},
{init,start_it,1,[]},
{init,start_em,1,[]}]}}
Probably needs a test case for that too
There was a problem hiding this comment.
Nevermind, had forgotten to refetch providers.
ferd
added a commit
that referenced
this pull request
Mar 8, 2015
update erlydtl compiler to output to _build, add simple test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.