Support macOS via https://github.com/erlef/otp_builds #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4151385 to
c9d7c22
Compare
904cea0 to
0b10410
Compare
0b10410 to
87b0c11
Compare
Comment on lines
+21
to
+22
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
This was GitHub. If you prefer I can push in a separate pull request to separate concerns.
paulo-ferraz-oliveira
commented
May 25, 2025
10000
Comment on lines
+44
to
+45
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
This was GitHub. If you prefer I can push in a separate pull request to separate concerns.
Comment on lines
+21
to
+22
| otp-version: ['27'] | ||
| elixir-version: ['v1.18', ''] |
There was a problem hiding this comment.
Took this time to bump these to more recent versions.
0f810bc to
3cb8754
Compare
3cb8754 to
28b2f97
Compare
|
There's a minor doc. update requirement, but apart from that we seem good to go. |
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
|
If CI's passing, I'm merging. I don't think there's hurry in releasing, since we have a couple of ongoing PRs, but I'm Ok to release nonetheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment this is created (as a Draft) most tests are passing locally, but I want to check behaviour in GHA CI as one would use the action.
Closes #54.
Further considerations
I took the time/chance to also act on some stuff the sec. bot found. The commits are easily identifiable.
I also retired 18.04 and 20.04 in this pull request since you can no longer consume them in GHA, apparently.