Don't rewrite app files if contents are the same #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing .app files to check if a rewrite is necessary do so by comparing erlang terms instead of bytes, the original .app might contain comments for example and cause unnecessary rewrites. This proves a problem when dealing with erts .app files that might be read-only at the origin and thus cause a failed release on relx that is uncalled for since there might have been no changes at all.
|
@tsloughter ready for review |
deadjdona
referenced
this pull request
in esl/MongooseIM
Oct 17, 2017
Sidestep permissions issue from #1170 while waiting for upstream fix for erlware/relx#564 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing .app files to check if a rewrite is
necessary do so by comparing erlang terms instead
of bytes, the original .app might contain comments
for example and cause unnecessary rewrites.
This proves a problem when dealing with erts .app
files that might be read-only at the origin and
thus cause a failed release on relx that is
uncalled for since there might have been no changes
at all.
This fixes #564 and erlang/rebar3#1441