8000 use copied erts dir when tar'ing even when the user sets the erts by tsloughter · Pull Request #884 · erlware/relx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use copied erts dir when tar'ing even when the user sets the erts #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

use copied erts dir when tar'ing even when the user sets the erts #884

merged 1 commit into from
Sep 2, 2021

Conversation

tsloughter
Copy link
Member

Fixes #877

@tsloughter
Copy link
Member Author

Ugh, I don't think we have a test for including an erts by path.

@elbrujohalcon any chance you could test this resolves your issue?

I'll figure out adding tests for include_erts stuff. I figure it can be simply still using the system's erts but setting it as a path. So would be checking that it gets the same result as {include_erts, true} I guess.

@tsloughter tsloughter requested a review from ferd September 2, 2021 14:27
@elbrujohalcon
Copy link

Not easily, no… since we use relx through rebar3…

@tsloughter
Copy link
Member Author

Ok, no problem, I'll try a quick local test. I put relx in _checkouts of rebar3 and then build a new escript. May just make sure it doesn't blow up if I put a erts dir to use in the configuration :). Then I can do a release, update the dep in rebar3 and I'll link you to the nightly rebar3 that gets published so you can verify it works before we cut a new rebar3. If it doesn't then should be simple enough fix for whatever is still an issue and a new relx version will be cut, and so on :)

@tsloughter
Copy link
Member Author

Verified.

Will merge once Fred approves. Undecided if I'll add a test as part of rebar3_tests or in the common test suite.

@tsloughter tsloughter merged commit 5587173 into erlware:master Sep 2, 2021
@tsloughter tsloughter deleted the use-copied-erts branch September 2, 2021 16:41
@elbrujohalcon
Copy link

I can confirm that the issue was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building a tar doesn't override the erl scr 396C ipt like building a release
3 participants
@tsloughter @elbrujohalcon @ferd
0