8000 add shelltest for pathname quoting in extended_start_script by sg2342 · Pull Request #919 · erlware/relx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add shelltest for pathname quoting in extended_start_script #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

add shelltest for pathname quoting in extended_start_script #919

merged 1 commit into from
Jun 13, 2022

Conversation

sg2342
Copy link
Contributor
@sg2342 sg2342 commented Jun 9, 2022

No description provided.

@ferd
Copy link
Collaborator
ferd commented Jun 10, 2022

I believe the file extension should be .test instead of .tests to run.

@sg2342 sg2342 force-pushed the extended_start_script_tests_pathname_escape branch from 39d8c01 to 3fa5f1d Compare June 10, 2022 02:49
@sg2342
Copy link
Contributor Author
sg2342 commented Jun 10, 2022

I believe the file extension should be .test instead of .tests to run.

sorry, i was confused by the shelltests/extended_start_script_tests/extended_start_script_tests.tests file that was already there (and was also disconnected from the automated tests because of the extension ... which is for the better since it fails).

Now i have to figure out a way to get the test working on the ubuntu-latest setup used in the github action. The approach in the PR does work with shelltest 1.9 and the FreeBSD /bin/sh.

@sg2342 sg2342 force-pushed the extended_start_script_tests_pathname_escape branch 2 times, most recently from 9af7496 to 6fe8201 Compare June 12, 2022 05:44
@ferd ferd merged commit 4baa294 into erlware:main Jun 13, 2022
@sg2342 sg2342 deleted the extended_start_script_tests_pathname_escape branch June 13, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sg2342 @ferd
0