8000 compile_dir return · Issue #121 · erlydtl/erlydtl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

compile_dir return #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidw opened this issue Jan 20, 2014 · 5 comments
Closed

compile_dir return #121

davidw opened this issue Jan 20, 2014 · 5 comments
Assignees
@kaos
Labels
compiler usability
Milestone
0.8.2

Comments

@davidw
Copy link
Contributor
davidw commented Jan 20, 2014

Commit 0cf2779 changed the return type from compile_dir, which was previously {ok, .....}.

This breaks anything (like Chicago Boss) that happened to depend on that result.

Not sure how or if this should be fixed.
@davidw davidw mentioned this issue Jan 20, 2014
Closed
@kaos
Copy link
Member
kaos commented Jan 21, 2014

I will look into this. I am currently away, but will be back later this week.

@ghost ghost assigned kaos Jan 21, 2014
davidw added a commit to davidw/erlydtl that referenced this issue Jan 21, 2014
@davidw
Return {ok, Result} rather than just Result.
34a7301 
erlydtl#121
@davidw
Copy link
Contributor Author
davidw commented Jan 21, 2014

It looks like it may not be a good idea to be calling that directly. erlydtl.erl calls into that module, and has dialyzer types indicating the return value should be ok.

@kaos
Copy link
Member
kaos commented Jan 21, 2014

The specs needs updating. Also, the compile_dir function should use the new collect_results function..
My apologies, I missed to check the compile_dir function prior to making the 0.8.1 release.

I'll have to look into writing some tests for the compile_dir function (as there remarkably are none already!).

@davidw
Copy link
Contributor Author
davidw commented Jan 21, 2014

Returning 'ok' seems to make rebar happy, however that works, so that is probably actually the best thing, at least from the erlydtl functions. Maybe the compiler ones can have {ok, Module}, and then erlydtl strips that down to ok? I don't quite see exactly how rebar calls in to things.

I figured out the compile_dir problem and should have a patch for that too.

@davidw
Copy link
Contributor Author
davidw commented Jan 21, 2014

Aha, here is the Rebar connection:

https://github.com/rebar/rebar/blob/master/src/rebar_erlydtl_compiler.erl

@davidw davidw mentioned this issue Jan 21, 2014
Closed
@kaos kaos closed this as completed in 26cb8fc Feb 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaos kaos

Labels
compiler usability
Projects
None yet
Milestone
0.8.2
Development

Successfully merging a pull request may close this issue.

Make the API match what Rebar wants davidw/erlydtl
2 participants
@davidw @kaos
0