8000 Add LFU eviction policy by erni27 · Pull Request #53 · erni27/imcache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add LFU eviction policy #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2024
Merged

Add LFU eviction policy #53

merged 4 commits into from
Jan 13, 2024

Conversation

erni27
Copy link
Owner
@erni27 erni27 commented Jan 9, 2024 •
edited
Loading

This PR:

  • adds new option WithMaxEntriesLimitOption allowing to configure used EvictionPolicy
  • deprecates WithMaxEntriesOption option
  • implements new eviction policy (LFU)

Partially fixes: #51

@erni27 erni27 added this to the 1.2.0 Release milestone Jan 13, 2024
@codecov-commenter
Copy link
codecov-commenter commented Jan 13, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (88192fa) 94.72% compared to head (1a4734f) 95.37%.

Files Patch % Lines
option.go 60.00% 2 Missing ⚠️
eviction.go 99.13% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   94.72%   95.37%   +0.64%     
==========================================
  Files           6        6              
  Lines         834      951     +117     
==========================================
+ Hits          790      907     +117     
- Misses         37       38       +1     
+ Partials        7        6       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erni27 erni27 marked this pull request as ready for review January 13, 2024 14:47
@erni27 erni27 merged commit 50ebc73 into master Jan 13, 2024
@erni27 erni27 deleted the add-lfu-eviction-policy branch January 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0 Release
Development

Successfully merging this pull request may close these issues.

Explore other eviction policies
2 participants
@erni27 @codecov-commenter
0