Paper results finalizing #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Plot fixes - Small path fixes in notebooks - Reran TRCWA vs GRCWA notebook
| @@ -65,7 +75,7 @@ def compute_spectrum_fdtd(permittivity, cfg: DotMap): | |||
| cfg, | |||
| include_object=False, | |||
| wavelength=physical_wavelengths[i], | |||
| permittivity=permittivity[:, :, :, i], | |||
| permittivity=None, | |||
There was a problem hiding this comment.
Why remove the permittivity?
There was a problem hiding this comment.
Ahh its only for the include objecet = False part, I see
There was a problem hiding this comment.
Yes I just wanted to make clear and sure that the value is not used
nidn/fdtd_integration/init_fdtd.py
Outdated
| detector_y -= cfg.FDTD_gridpoints_from_material_to_detector | ||
|
|
||
| logger.trace( | ||
| "Placing detector at " |
There was a problem hiding this comment.
Placing detectors at? Both are x coordinate of transmission or reflection detector
torbjornstoro
approved these changes
May 6, 2022
gomezzz
commented
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Ran tests, ran notebooks