Several small changes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed materials which have eps < 0 in that spectrum
- Changed lower end of target freq to 250nm
htoftevaag
reviewed
Aug 23, 2021
nidn/trcwa/constants.py
Outdated
| @@ -1,14 +1,14 @@ | |||
| import torch | |||
|
|
|||
| # NB: Here, we assume that the standard is micrometre (um). | |||
| TRCWA_UNIT_MAGNITUDE = 10 ** (-6) | |||
| TRCWA_UNIT_MAGNITUDE = 10 ** (-7) | |||
There was a problem hiding this comment.
I'm not fully aware of the entire code base, but I think this isn't the solution to changing the size of the grid.
When initialising the grid, if we write L1 = 1 (and L2 = 1) and freq = 0.5, then the relation between these is the only thing that matters.
We can decide ourselves if the L1 = 1 means 1 um or 1 nm or 1 * 10^-7 m.
The wavelength is in this case 1 / 0.5 = 2 um or 2 nm or 2 * 10^-7 m.
If we want to reduce the grid size, then changing L1 and L2 to 0.1 instead of 1 should be enough - unless I have misunderstood something.
- Fixed frequency sorting in target frequencies - Reverted MAGNITUDE change - Changed default L for TRCWA
htoftevaag
approved these changes
Aug 24, 2021
…nto Several-small-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge all PR <= 10 first