8000 Investigate wave length / freq snafu by gomezzz · Pull Request #20 · esa/NIDN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Investigate wave length / freq snafu #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2021
Merged

Investigate wave length / freq snafu #20

merged 3 commits into from
Aug 25, 2021

Conversation

gomezzz
Copy link
Collaborator
@gomezzz gomezzz commented Aug 24, 2021

Description

First merge #19

  • Fixed the frequency conversion in plot_spectrum
  • Undid magnitude change in frequency conversion (Think we forgot to revert that, we only wanted to change L afaik?)

How Has This Been Tested?

  • Ran training notebook
  • Ran tests

Related Pull Requests

gomezzz added 3 commits August 24, 2021 14:53
@gomezzz
Added automatic baseline detection in eps per point plot and fixed WL…
1ceb3c0 
… bug
@gomezzz
- Added material grid plot
3b3a005 
- Small fix in find_closest_material
- Cleaned up some imports
- Added plot to training NB
@gomezzz
- Fixed frequency conversion in plot_spectra
45f3ee2 
- Reverted unit magnitude to -6
@gomezzz gomezzz requested a review from htoftevaag August 24, 2021 15:04
@gomezzz gomezzz mentioned this pull request Aug 24, 2021
Merged
@gomezzz gomezzz changed the base branch from main to Make-noise-addition-symmetric August 25, 2021 08:06
@gomezzz gomezzz changed the base branch from Make-noise-addition-symmetric to main August 25, 2021 08:06
@htoftevaag htoftevaag merged commit 537bd00 into main Aug 25, 2021
@htoftevaag htoftevaag deleted the Investigate-wave-length-/-freq-snafu branch August 25, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htoftevaag htoftevaag htoftevaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomezzz @htoftevaag
0