8000 Results collection by gomezzz · Pull Request #33 · esa/NIDN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Results collection #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 24, 2021
Merged

Results collection #33

merged 12 commits into from
Sep 24, 2021

Conversation

gomezzz
Copy link
Collaborator
@gomezzz gomezzz commented Aug 30, 2021

Description

Merge before #32

  • Various plot improvements
  • Added function to save all plots
  • Added flag for freq_distribution [linear,log]
  • Added flag for avoiding zero eps
  • Allowed negative eps
  • Added flag to enable cuda (needs testing)
  • Changed training to pick lowest loss not just lowest spectrum loss
  • Added name for runs to cfg
  • Changed instability warning to be printed at max(L_grid * target_Freq) > 3.0
  • Minor changes to default cfg
  • Removed training NB
  • Minimal changes in run_cfgs script

How Has This Been Tested?

  • Ran tests
  • Ran example notebooks and some experiments

Related Pull Requests

gomezzz added 8 commits August 25, 2021 15:42
@gomezzz
- Small refactoring in plots
3905eed 
- Adjusting default cfg
@gomezzz
Merge branch 'main' into Example-notebook-for-users
19e4145
@gomezzz
- Removed training NB
6765d58 
- Minimal change in Running TRCWA NB
- Small fix in save_all_plots
- Small adjustment in plot_spectrum
@gomezzz
- minimal changes
986f557 
- added NB
@gomezzz
WIP
734eb0f
@gomezzz
Added freq distribution parameter
d7b0448
@gomezzz
- Added GPU support option
ddf850d 
- Added zero eps avoidance
- Added freq distribution setting
@gomezzz
- Refactored zero avoidance
2cac70f
@gomezzz gomezzz added the WIP label Aug 30, 2021
gomezzz
gomezzz commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author
@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htoftevaag confirmed their approval 🙏

@gomezzz gomezzz merged commit bfe19dc into main Sep 24, 2021
@gomezzz gomezzz deleted the Results-collection branch September 24, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gomezzz
0