8000 Wi adding ricker wavelet by torbjornstoro · Pull Request #77 · esa/NIDN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wi adding ricker wavelet #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 20, 2022
Merged

Wi adding ricker wavelet #77

merged 6 commits into from
Apr 20, 2022

Conversation

torbjornstoro
Copy link
Collaborator

Description

Summary of changes

  • Added ricker wavelet in fdtd source
  • Implemented this such that it easy to change for a user

@torbjornstoro torbjornstoro requested a review from gomezzz April 19, 2022 14:54
@torbjornstoro torbjornstoro 8000 changed the base branch from main to waveregime-internship April 19, 2022 14:55
gomezzz
gomezzz requested changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator
@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as dicussed

@torbjornstoro torbjornstoro requested a review from gomezzz April 20, 2022 08:51
gomezzz
gomezzz requested changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator
@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@torbjornstoro torbjornstoro requested a review from gomezzz April 20, 2022 10:03
@torbjornstoro torbjornstoro merged commit 9f76397 into waveregime-internship Apr 20, 2022
@torbjornstoro torbjornstoro deleted the WI_adding_ricker_wavelet branch April 20, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torbjornstoro @gomezzz
0