8000 Fixed peak_finding implementation to get correct spectrum by torbjornstoro · Pull Request #86 · esa/NIDN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed peak_finding implementation to get correct spectrum #86

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fixed peak_finding implementation to get correct spectrum #86

merged 1 commit into from
Apr 25, 2022

Conversation

torbjornstoro
Copy link
Collaborator

Description

Summary of changes

  • Changed implementation of peak finding, previously only used value of first peak in ms calculation, now uses entire signal from first to last peak

How Has This Been Tested?

-Verified correct spectrum from FDTD

gomezzz
gomezzz approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator
@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@torbjornstoro torbjornstoro merged commit 4e99d38 into main Apr 25, 2022
@torbjornstoro torbjornstoro deleted the WI_fix_peak_finding branch April 25, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torbjornstoro @gomezzz
0