Bugfix of layer thickness #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
requested changes
Apr 28, 2022
| @@ -29,7 +29,7 @@ def init_fdtd(cfg: DotMap, include_object, wavelength, permittivity): | |||
| """ | |||
| set_backend("torch") | |||
| if (len(cfg.PER_LAYER_THICKNESS) == 1) and (cfg.N_layers > 1): | |||
| cfg.PER_LAYER_THICKNESS = [cfg.PER_LAYER_THICKNESS] * cfg.N_layers | |||
| cfg.PER_LAYER_THICKNESS = cfg.PER_LAYER_THICKNESS * cfg.N_layers | |||
There was a problem hiding this comment.
I don't think you want to do this, this will e.g. for 5 layers and thickness 0.1 per layer make the thickness 0.5?
There was a problem hiding this comment.
Unless Per layer thickness is a one element list 🤔 , I guess? But then should check here just to be sure that it is a list and above doesn't happen?
There was a problem hiding this comment.
PER_LAYER_THICKNESS is always a list, validate config catches this
gomezzz
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title
Resolved Issues
How Has This Been Tested?