8000 Pass output_dir as str to wandb.init() by jonghwanhyeon · Pull Request #4607 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pass output_dir as str to wandb.init() #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

Pass output_dir as str to wandb.init() #4607

merged 1 commit into from
Aug 30, 2022

Conversation

jonghwanhyeon
Copy link
Contributor

The current version of wandb requires a dir parameter of type str in wandb.init().

wandb: WARNING Invalid value for property root_dir: experiments/22k/tts_train_multi_spk_vits_raw_phn_none. This will raise an error in the future.

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 1043, in init
    run = wi.init()
  File "/usr/local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 553, in init
    manager._inform_init(settings=self.settings, run_id=self.settings.run_id)
  File "/usr/local/lib/python3.9/site-packages/wandb/sdk/wandb_manager.py", line 161, in _inform_init
    svc_iface._svc_inform_init(settings=settings, run_id=run_id)
  File "/usr/local/lib/python3.9/site-packages/wandb/sdk/service/service_sock.py", line 36, in _svc_inform_init
    _pbmap_apply_dict(inform_init._settings_map, settings_dict)
  File "/usr/local/lib/python3.9/site-packages/wandb/sdk/service/service_base.py", line 53, in _pbmap_apply_dict
    raise Exception("unsupported type")

@mergify mergify bot added the ESPnet2 label Aug 30, 2022
@kamo-naoyuki kamo-naoyuki added this to the v.202209 milestone Aug 30, 2022
@codecov
Copy link
codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #4607 (f0edec2) into master (13db69d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4607      +/-   ##
==========================================
+ Coverage   83.04%   83.06%   +0.01%     
==========================================
  Files         508      508              
  Lines       43631    43646      +15     
==========================================
+ Hits        36235    36253      +18     
+ Misses       7396     7393       -3
Flag Coverage Δ
test_integration_espnet1 66.36% <ø> (ø)
test_integration_espnet2 49.53% <ø> (ø)
test_python 70.60% <ø> (+0.07%) ⬆️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/tasks/abs_task.py 75.48% <ø> (ø)
espnet/nets/pytorch_backend/e2e_vc_transformer.py 86.72% <0.00%> (+0.11%) ⬆️
espnet/nets/pytorch_backend/e2e_vc_tacotron2.py 80.48% <0.00%> (+0.15%) ⬆️
espnet/nets/pytorch_backend/e2e_asr_maskctc.py 87.40% <0.00%> (+0.18%) ⬆️
espnet/nets/chainer_backend/e2e_asr_transformer.py 68.89% <0.00%> (+0.20%) ⬆️
espnet/nets/pytorch_backend/lm/seq_rnn.py 86.88% <0.00%> (+0.21%) ⬆️
espnet/distributed/pytorch_backend/launch.py 82.75% <0.00%> (+1.80%) ⬆️
espnet/nets/pytorch_backend/gtn_ctc.py 43.54% <0.00%> (+1.88%) ⬆️
.../nets/pytorch_backend/transformer/encoder_layer.py 98.07% <0.00%> (+3.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kamo-naoyuki
Copy link
Collaborator

I confirmed the error. Thank you for contributing!

@kamo-naoyuki kamo-naoyuki added the auto-merge Enable auto-merge label Aug 30, 2022
@mergify mergify bot merged commit e5d133c into espnet:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge Enable auto-merge Bugfix ESPnet2
Projects
None yet
Milestone
v.202209
Development

Successfully merging this pull request may close these issues.
2 participants
@jonghwanhyeon @kamo-naoyuki
0