8000 update pyopenjtalk version to 0.3.0 by kan-bayashi · Pull Request #4912 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update pyopenjtalk version to 0.3.0 #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2023
Merged

update pyopenjtalk version to 0.3.0 #4912

merged 4 commits into from
Feb 6, 2023

Conversation

kan-bayashi
Copy link
Member
@kan-bayashi kan-bayashi commented Feb 4, 2023 •
edited
Loading

Current pyopenjtalk version v0.1.6 is not compatible with python 3.10.
This PR updates from v0.1.6 to v0.3.0.

@mergify mergify bot added the Installation label Feb 4, 2023
@kan-bayashi kan-bayashi mentioned this pull request Feb 4, 2023
Merged
@ftshijt
Copy link
Collaborator
ftshijt commented Feb 6, 2023

May I know if we would significantly differ in the g2p method for the version updates? Since we are at the time releasing a benchmark with a prerequisite on it, it would be great if we could stick to a stable version.

@kan-bayashi
Copy link
Member Author

I think only the difference is interface. Let me check.
I will modify the code to accept version v0.1.6 ~ v0.3.0.

@mergify mergify bot added the ESPnet2 label Feb 6, 2023
@codecov
Copy link
codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #4912 (56ddfa3) into master (1f6caeb) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #4912      +/-   ##
==========================================
- Coverage   76.58%   76.58%   -0.01%     
==========================================
  Files         603      603              
  Lines       53730    53731       +1     
==========================================
  Hits        41148    41148              
- Misses      12582    12583       +1
Flag Coverage Δ
test_integration_espnet1 66.33% <ø> (ø)
test_integration_espnet2 47.59% <33.33%> (+<0.01%) ⬆️
test_python 66.45% <88.88%> (-0.01%) ⬇️
test_utils 23.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/text/phoneme_tokenizer.py 75.16% <88.88%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kan-bayashi kan-bayashi added the auto-merge Enable auto-merge label Feb 6, 2023
@mergify mergify bot merged commit ecc79f0 into master Feb 6, 2023
@mergify mergify bot deleted the update-pyopenjtalk branch February 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge Enable auto-merge ESPnet2 Installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kan-bayashi @ftshijt
0