8000 Reduce ffmpeg installation time in ci by kan-bayashi · Pull Request #5356 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce ffmpeg installation time in ci #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2023
Merged

Reduce ffmpeg installation time in ci #5356

merged 1 commit into from
Jul 23, 2023

Conversation

kan-bayashi
Copy link
Member

What?

  • Install ffmpeg with apt for ubuntu in ci
  • if ffmpeg is available, skip ffmpeg installation

Why?

  • Sometimes ffmpeg installation is failed due to overaccess.

See also

https://github.com/espnet/espnet/actions/runs/5633059176/job/15261578319

@mergify mergify bot added the Installation label Jul 23, 2023
@kan-bayashi kan-bayashi changed the title reduce ffmpeg installation time in ci Reduce ffmpeg installation time in ci Jul 23, 2023
@kan-bayashi kan-bayashi added the auto-merge Enable auto-merge label Jul 23, 2023
@kan-bayashi kan-bayashi force-pushed the fix/fix-ffmpeg-installation branch from 1580b0f to 364fb3f Compare July 23, 2023 01:09
@mergify mergify bot added the CI Travis, Circle CI, etc label Jul 23, 2023
@codecov
Copy link
codecov bot commented Jul 23, 2023 •
edited
Loading

Codecov Report

Merging #5356 (364fb3f) into master (83fec3a) will increase coverage by 3.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5356      +/-   ##
==========================================
+ Coverage   72.37%   76.11%   +3.74%     
==========================================
  Files         672      672              
  Lines       59859    59859              
==========================================
+ Hits        43321    45563    +2242     
+ Misses      16538    14296    -2242
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 47.92% <ø> (?)
test_python_espnet1 20.51% <ø> (ø)
test_python_espnet2 51.35% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added this to the v.202307 milestone Jul 23, 2023
73AB
@kan-bayashi kan-bayashi merged commit 3e266b4 into espnet:master Jul 23, 2023
@kan-bayashi kan-bayashi deleted the fix/fix-ffmpeg-installation branch July 23, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge Enable auto-merge CI Travis, Circle CI, etc Installation
Projects
None yet
Milestone
v.202307
Development

Successfully merging this pull request may close these issues.
2 participants
@kan-bayashi @sw005320
0