8000 Fix except by takenori-y · Pull Request #5567 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix except #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix except #5567

merged 1 commit into from
Nov 27, 2023

Conversation

takenori-y
Copy link
Contributor

What?

Use a correct one-line except.

Why?

from espnet2.tasks.tts import TTSTask

causes a segmentation fault in my environment (Python 3.9.0)

See also

@mergify mergify bot added the ESPnet2 label Nov 27, 2023
@codecov Codecov
Copy link
codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d325413) 76.54% compared to head (87e3053) 76.54%.

Files Patch % Lines
espnet2/fileio/score_scp.py 0.00% 2 Missing ⚠️
espnet2/bin/uasr_inference_k2.py 0.00% 1 Missing ⚠️
espnet2/fst/lm_rescore.py 0.00% 1 Missing ⚠️
espnet2/uasr/espnet_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5567   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files         720      720           
  Lines       66599    66599           
=======================================
  Hits        50975    50975           
  Misses      15624    15624
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 50.10% <0.00%> (ø)
test_python_espnet1 19.08% <0.00%> (ø)
test_python_espnet2 52.38% <0.00%> (ø)
test_utils 22.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 added this to the v.202312 milestone Nov 27, 2023
@sw005320
Copy link
Contributor

Thanks a lot, @takenori-y!

@sw005320 sw005320 merged commit 7e66c04 into espnet:master Nov 27, 2023
@takenori-y takenori-y deleted the except branch November 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix ESPnet2
Projects
None yet
Milestone
v.202312
Development

Successfully merging this pull request may close these issues.
2 participants
@takenori-y @sw005320
0