Add Encodec features for Codec toolkit #5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Since it is mixed with the current decoding and scoring PR, I will review it again after we first merge that one. Thanks for the in-time PR! |
ftshijt
reviewed
May 8, 2024
espnet2/gan_codec/encodec/encodec.py
Outdated
Comment on lines
81
to
85
| "fs": 24000, | ||
| "n_fft": 1024, | ||
| "hop_length": 256, | ||
| "win_length": None, | ||
| "window": "hann", |
There was a problem hiding this comment.
You might consider to follow the new setup for multi-scale mel loss?
espnet2/gan_codec/encodec/encodec.py
Outdated
| use_loss_balancer: bool = False, | ||
| balance_ema_decay: float = 0.99, | ||
| ): | ||
| # (Jinchuan) re-apply everything except the discriminator config. |
There was a problem hiding this comment.
One TODO here, to add the docstring
There was a problem hiding this comment.
For the note consistency, please use:
# NOTE(jincuan): ...
Also for TODO
| ) | ||
|
|
||
|
|
||
| def apply_parametrization_norm(module: nn.Module, norm: str = "none"): |
There was a problem hiding this comment.
For consistency, I think many of the modules are already in shared, could you please double check in case?
|
Thanks for your contribution! Looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add several Encodec features into the codec toolkit: https://arxiv.org/abs/2210.13438
@ftshijt