8000 Add HiFiCodec model by RayYuki · Pull Request #5898 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add HiFiCodec model #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Add HiFiCodec model #5898

merged 6 commits into from
Oct 29, 2024

Conversation

RayYuki
Copy link
@RayYuki RayYuki commented Sep 10, 2024

What?

Add HiFiCodec model.

Why?

Support more codec model.

@mergify mergify bot added the ESPnet2 label Sep 10, 2024
@ftshijt ftshijt added this to the v.202405 milestone Sep 12, 2024
@ftshijt
Copy link
Collaborator
ftshijt commented Sep 20, 2024

Thanks for your great contribution!

For the following up, could you please:

  • fix the CI error
  • add the model config in libritts recipe (as we noted in the paper)

Thanks again!

@RayYuki
Copy link
Author
RayYuki commented Sep 25, 2024

Thanks for your great contribution!

For the following up, could you please:

  • fix the CI error
  • add the model config in libritts recipe (as we noted in the paper)

Thanks again!

I fixed the CI error but some of the tests were failed because of the network. Could you review them?
Thank you!

@Fhrozen Fhrozen modified the milestones: v.202409, v.202412 Oct 1, 2024
@ftshijt
Copy link
Collaborator
ftshijt commented Oct 23, 2024

Looks great to me! I will merge it after the CI tests. Thank you very much for your contribution!

@ftshijt ftshijt merged commit 797d07f into espnet:master Oct 29, 2024
28 of 38 checks passed
Shikhar-S pushed a commit to Shikhar-S/espnet that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0