8000 Update tools/README.md by popcornell · Pull Request #6030 · espnet/espnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update tools/README.md #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2025
Merged

Update tools/README.md #6030

merged 2 commits into from
Jan 30, 2025

Conversation

popcornell
Copy link
Contributor

I think that the most failsafe installation procedure should fix python version of conda env to 3.8. Tried a bunch of times for me it breaks with 3.10 and 3.12 always run into different problems

@popcornell
Update README.md
8b8c9e5 
I think that the most failsafe installation procedure should fix python version of conda env to 3.8. 
Tried a bunch of times for me it breaks with 3.10 and 3.12 always run into different problems
@popcornell
Update README.md
7d60302
@popcornell popcornell changed the title Update README.md Update tools/README.md Jan 30, 2025
@sw005320 sw005320 added this to the v.202503 milestone Jan 30, 2025
@sw005320
Copy link
Contributor

Make sense.
Actually, our demo also uses 3.8

@popcornell
Copy link
Contributor Author

The documentation in https://espnet.github.io/espnet/installation.html also fixes it to 3.8
I think also here is good to keep it this way.

@sw005320 sw005320 merged commit f370186 into espnet:master Jan 30, 2025
38 checks passed
@sw005320
Copy link
Contributor

Thanks!

@codecov Codecov
Copy link
codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.19%. Comparing base (29a6e5a) to head (7d60302).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (29a6e5a) and HEAD (7d60302). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (29a6e5a) HEAD (7d60302)
test_integration_espnet2 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6030      +/-   ##
==========================================
- Coverage   47.45%   38.19%   -9.26%     
==========================================
  Files         531      566      +35     
  Lines       48027    51080    +3053     
==========================================
- Hits        22790    19511    -3279     
- Misses      25237    31569    +6332
Flag Coverage Δ
test_integration_espnet2 ?
test_integration_espnetez 38.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Shikhar-S pushed a commit to Shikhar-S/espnet that referenced this pull request Mar 13, 2025
@sw005320
Merge pull request espnet#6030 from popcornell/patch-5
2983ab0 
Update tools/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Installation README
Projects
None yet
Milestone
v.202503
Development

Successfully merging this pull request may close these issues.
2 participants
@popcornell @sw005320
0