Switch to new esphome configuration (current one is deprecated); fix for Issue #323 #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, without this patch it's not possible to use this project with any but the vanilla esp32. For example, I would like to use it for Atom S3 Lite which is an esp32s3. |
|
Hi @segdy - thanks for suggesting this change. Could you take a look at the examples in this folder and see if that solves your issue? Edit: This does not change that the file you changed currently uses a deprecated format for specifying framework. |
|
Thank you, almost. It does not have an option to specify the framework though (although, now that the esp32: section exists, I could probably extend it in my yaml file |
|
Closing because this would be a breaking change. Use one of the esp32s3.yaml variants in the build-yaml directory and extend it to specify framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code base uses old and deprecated esphome configuration in which board parameters are configured directly in esphome section. However this is very problematic because it prevents anyone from adjusting details, such as specifying framework (arduino vs idf) or a specific variant or anything that required options under the $platform section (e.g. esp32 section).