8000 Add state_class to furnace and odu sensors to force number class, add stats by jdanders · Pull Request #466 · esphome-econet/esphome-econet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add state_class to furnace and odu sensors to force number class, add stats #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

Add state_class to furnace and odu sensors to force number class, add stats #466

merged 2 commits into from
Apr 1, 2025

Conversation

jdanders
Copy link
Contributor

Some of the values were showing as state instead of numbers in Home Assitant, which means there was no history graph, just history state changes. This both fixes that and adds long term statistics to everything

@jdanders
Add state_class to furnace and odu sensors to force number class and …
48d059b 
…allow stats gathering

Some of the values were showing as state instead of numbers in Home Assitant, which means there was no history graph, just history state changes. This both fixes that and adds long term statistics to everything
@justbruce
Copy link
Contributor

FURNHBTU and FURNLBTU are static - they simply report the programmed values.

So they might be a waste of space to store in the history files of HA.

@jdanders
Copy link
Contributor Author

Good point, I've removed those two from statistics.

I would hope that HA stats are efficient enough not to waste extra space on static stats, but it makes sense not to try.

@tronikos
Copy link
Member

I would hope that HA stats are efficient enough not to waste extra space on static stats, but it makes sense not to try.

We don't send unchanged values to Home Assistant, see

esphome-econet/components/econet/econet.cpp

Line 592 in 15c334a

ESP_LOGV(TAG, "Not sending unchanged value for datapoint %s", specific.name.c_str());

But even if we were, the Home Assistant recorder also skips unchanged values.

barndawgie
barndawgie approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member
@barndawgie barndawgie left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the contribution!

@barndawgie barndawgie merged commit 02db210 into esphome-econet:main Apr 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barndawgie barndawgie barndawgie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdanders @justbruce @tronikos @barndawgie
0