8000 [internal_temperature] Add p4 ifdefs by swoboda1337 · Pull Request #8484 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[internal_temperature] Add p4 ifdefs #8484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

swoboda1337
Copy link
Contributor

What does this implement/fix?

Add p4 ifdefs to support P4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @Mat931, mind taking a look at this pull request as it has been labeled with an integration (internal_temperature) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@swoboda1337 swoboda1337 changed the title {internal_temperature] Add p4 ifdefs [internal_temperature] Add p4 ifdefs Mar 29, 2025
@codecov-commenter
Copy link
codecov-commenter commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.91%. Comparing base (4d8b5ed) to head (d13f087).
Report is 2248 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8484      +/-   ##
==========================================
+ Coverage   53.70%   54.91%   +1.20%     
==========================================
  Files          50       50              
  Lines        9408     9913     +505     
  Branches     1654     1354     -300     
==========================================
+ Hits         5053     5444     +391     
- Misses       4056     4125      +69     
- Partials      299      344      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesserockz jesserockz merged commit 4a65fd7 into esphome:dev Apr 17, 2025
27 checks passed
mgiacomelli pushed a commit to mgiacomelli/esphome that referenced this pull request Apr 20, 2025
@jesserockz jesserockz mentioned this pull request May 13, 2025
@jesserockz jesserockz mentioned this pull request May 21, 2025
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0