Remove duplicate co2 and pressure constants #8583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Azimath, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @martgras, @sjtrny, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8583 +/- ##
==========================================
+ Coverage 53.70% 56.49% +2.78%
==========================================
Files 50 50
Lines 9408 9888 +480
Branches 1654 1337 -317
==========================================
+ Hits 5053 5586 +533
+ Misses 4056 3953 -103
- Partials 299 349 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
jesserockz
approved these changes
Apr 17, 2025
mgiacomelli
added a commit
to mgiacomelli/esphome
that referenced
this pull request
Apr 20, 2025
Merged
Merged
sa-crespo
pushed a commit
to sa-crespo/esphome
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently various CO2 and pressure sensors define several identical constants. This PR moves them to const.py.
This is needed for #8575 to apply cleanly.
Checklist:
tests/folder).