10000 [online_image] Fix printf format; comment fixes by clydebarrow · Pull Request #8607 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[online_image] Fix printf format; comment fixes #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

[online_image] Fix printf format; comment fixes #8607

merged 1 commit into from
Apr 23, 2025
+5 −5

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

  • Fix a printf format specifier;
  • Fix some #endif comments

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • host

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@clydebarrow clydebarrow added this to the 2025.4.1 milestone Apr 22, 2025
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 22:22
@probot-esphome
Copy link

Hey there @guillempages, mind taking a look at this pull request as it has been labeled with an integration (online_image) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copilot
Copilot AI reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A fix focused on improving code quality for the online image component by correcting the printf format specifier and updating conditional directive comments.

  • Update log message format specifier from "%d" to "%zu" to correctly reflect the size_t type of total_size.
  • Update end-of-if comments to use the "USE_ONLINE_IMAGE_BMP_SUPPORT" and "USE_ONLINE_IMAGE_PNG_SUPPORT" macros for better clarity and consistency.

@clydebarrow
Copy link
Contributor Author

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#8607
    components: [online_image]
    refresh: 1h

(Added by the PR bot)

@codecov-commenter
Copy link
codecov-commenter commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.64%. Comparing base (4d8b5ed) to head (9a7f782).
Report is 2421 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8607      +/-   ##
==========================================
+ Coverage   53.70%   56.64%   +2.93%     
==========================================
  Files          50       50              
  Lines        9408     9907     +499     
  Branches     1654     1338     -316     
==========================================
+ Hits         5053     5612     +559     
+ Misses       4056     3946     -110     
- Partials      299      349      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kbx81
kbx81 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member
@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍻

@kbx81 kbx81 merged commit 89b1b12 into esphome:dev Apr 23, 2025
28 checks passed
jesserockz pushed a commit that referenced this pull request Apr 28, 2025
@clydebarrow @jesserockz
[online_image] Fix printf format; comment fixes (#8607)
b940db6
@jesserockz jesserockz mentioned this pull request Apr 28, 2025
Merged
@clydebarrow clydebarrow deleted the online-image-format branch April 29, 2025 01:09
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
@clydebarrow @sa-crespo
[online_image] Fix printf format; comment fixes (esphome#8607)
88b7187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@kbx81 kbx81 kbx81 approved these changes

Assignees

@guillempages guillempages

Labels
bugfix by-code-owner cherry-picked integration: online_image small-pr
Projects
None yet
Milestone
2025.4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@clydebarrow @codecov-commenter @kbx81 @guillempages @jesserockz
0