8000 Update ens160_base.cpp – fix wrong double negative by steffenbanhardt · Pull Request #8639 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ens160_base.cpp – fix wrong double negative #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update ens160_base.cpp – fix wrong double negative #8639

merged 1 commit into from
Apr 28, 2025

Conversation

steffenbanhardt
Copy link
Contributor

The Validity Flag means „no valid output“

What does this implement/fix?

just a typo in the Validity Flag

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • [ X ] Other

@steffenbanhardt
Update ens160_base.cpp – fix wrong double negative
32f735d 
The Validity Flag means „no valid output“
@probot-esphome
Copy link

Hey there @latonita, @vincentscode, mind taking a look at this pull request as it has been labeled with an integration (ens160_base) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link
codecov-commenter commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.65%. Comparing base (4d8b5ed) to head (32f735d).
Report is 2429 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8639      +/-   ##
==========================================
+ Coverage   53.70%   56.65%   +2.94%     
==========================================
  Files          50       50              
  Lines        9408     9906     +498     
  Branches     1654     1338     -316     
==========================================
+ Hits         5053     5612     +559     
+ Misses       4056     3945     -111     
- Partials      299      349      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vincentscode
vincentscode approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor
@vincentscode vincentscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jesserockz jesserockz added this to the 2025.4.1 milestone Apr 28, 2025
@jesserockz jesserockz merged commit 3291a11 into esphome:dev Apr 28, 2025
28 checks passed
jesserockz pushed a commit that referenced this pull request Apr 28, 2025
@steffenbanhardt @jesserockz
Update ens160_base.cpp – fix wrong double negative (#8639)
f096567
@jesserockz jesserockz mentioned this pull request Apr 28, 2025
Merged
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
@steffenbanhardt @sa-crespo
Update ens160_base.cpp – fix wrong double negative (esphome#8639)
655c12c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesserockz jesserockz jesserockz approved these changes

@vincentscode vincentscode vincentscode approved these changes

Assignees
No one assigned
Labels
cherry-picked integration: ens160_base small-pr
Projects
None yet
Milestone
2025.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenbanhardt @codecov-commenter @jesserockz @vincentscode
0