[esp32_ble] Remove explicit and now incorrect ble override for esp32-c6 #8643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Rapsssito, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the explicit and now incorrect BLE override for ESP32-C6 by deleting the dedicated configuration header and simplifying the BLE controller initialization to use the default configuration.
- Removed the ESP32-C6 specific BT_CONTROLLER_CONFIG from const_esp32c6.h
- Updated ble.cpp to always use BT_CONTROLLER_INIT_CONFIG_DEFAULT() for BLE controller initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| esphome/components/esp32_ble/const_esp32c6.h | Removed file containing the outdated ESP32-C6 BLE configuration |
| esphome/components/esp32_ble/ble.cpp | Removed conditional inclusion and usage of specialized ESP32-C6 BLE override |
Comments suppressed due to low confidence (1)
esphome/components/esp32_ble/ble.cpp:126
- After removing the specialized ESP32-C6 override, verify that BT_CONTROLLER_INIT_CONFIG_DEFAULT() provides the appropriate BLE configuration for the ESP32-C6. Consider adding a platform-specific comment if any future adjustments are needed.
esp_bt_controller_config_t cfg = BT_CONTROLLER_INIT_CONFIG_DEFAULT();
jesserockz
added a commit
to esphome/firmware
that referenced
this pull request
Apr 28, 2025
jesserockz
added a commit
that referenced
this pull request
May 11, 2025
Merged
sa-crespo
pushed a commit
to sa-crespo/esphome
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
In #6734, I added the C6 file as the idf version we were referencing did not have a matching one.
Now we are using 5.1.X, we can remove this override and just use the provided values.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: