8000 Add GDEY0583T81 support by myllyja · Pull Request #8668 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add GDEY0583T81 support #8668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2025
Merged

Add GDEY0583T81 support #8668

merged 4 commits into from
May 3, 2025

Conversation

myllyja
Copy link
Contributor
@myllyja myllyja commented May 1, 2025 •
edited
Loading

What does this implement/fix?

Adds support for the 5.83" Good Display GDEY0583T81 E-paper variant

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • none

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

display:
  - platform: waveshare_epaper
    id: "disp"
    cs_pin: GPIO3
    dc_pin: GPIO5
    busy_pin:
      number: GPIO4
      inverted: true
    reset_pin: GPIO2
    model: gdey0583t81
    full_update_every: 10
    update_interval: 10s
    auto_clear_enabled: true
    lambda: |-
      // Drawing random lines to test the partial update and ghosting effects with short update interval
      int x1 = rand() % 648;
      int y1 = rand() % 480;
      int x2,y2;

      for (int i = 0; i < 20; i++) {
        x2 = rand() % 648;
        y2 = rand() % 480;

        it.line(x1, y1, x2, y2);
        x1 = x2;
        y1 = y2;
      }

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@myllyja myllyja requested a review from clydebarrow as a code owner May 1, 2025 15:27
@probot-esphome
Copy link
probot-esphome bot commented May 1, 2025

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (waveshare_epaper) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link
codecov-commenter commented May 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.61%. Comparing base (4d8b5ed) to head (9980abd).
Report is 2457 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8668      +/-   ##
==========================================
+ Coverage   53.70%   56.61%   +2.90%     
==========================================
  Files          50       50              
  Lines        9408     9921     +513     
  Branches     1654     1340     -314     
==========================================
+ Hits         5053     5617     +564     
+ Misses       4056     3955     -101     
- Partials      299      349      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@myllyja myllyja mentioned this pull request May 1, 2025
Merged
3 tasks
clydebarrow
clydebarrow requested changes May 1, 2025
View reviewed changes
@esphome esphome bot marked this pull request as draft May 1, 2025 22:03
@esphome
Copy link
esphome bot commented May 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@myllyja myllyja marked this pull request as ready for review May 2, 2025 14:25
@esphome esphome bot requested a review from clydebarrow May 2, 2025 14:25
@clydebarrow clydebarrow merged commit 8aff6d2 into esphome:dev May 3, 2025
24 checks passed
@myllyja myllyja deleted the gdey0583t81 branch May 3, 2025 16:30
@jesserockz jesserockz mentioned this pull request May 13, 2025
Merged
@jesserockz jesserockz mentioned this pull request May 21, 2025
Merged
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
@myllyja @sa-crespo
Add GDEY0583T81 support (esphome#8668)
ab83b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clydebarrow clydebarrow clydebarrow approved these changes

Assignees

@clydebarrow clydebarrow

Labels
integration: waveshare_epaper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myllyja @codecov-commenter @clydebarrow
0