[valve] Tidy up template publish action location #8731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Pull Request Overview
This PR tidies up the location of the valve publish action by removing the generic ValvePublishAction from the global valve component and relocating a refined TemplateValvePublishAction into the template valve component.
- Removed the redundant ValvePublishAction from esphome/components/valve/automation.h
- Added a new TemplateValvePublishAction implementation in esphome/components/template/valve/automation.h
- Updated the action registration and code generation in esphome/components/template/valve/init.py and relevant test configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/template/common.yaml | Adds a test configuration for the new TemplateValvePublishAction with state set to CLOSED |
| esphome/components/valve/automation.h | Removes the redundant ValvePublishAction class |
| esphome/components/template/valve/automation.h | Adds the new TemplateValvePublishAction class using the Parented pattern for TemplateValve |
| esphome/components/template/valve/init.py | Modifies the action registration and code generation to support the refactored action |
Comments suppressed due to low confidence (3)
tests/components/template/common.yaml:177
- Consider adding tests specific to TemplateValvePublishAction behavior to verify that state transitions (eg. CLOSED) are handled correctly.
- valve.template.publish:
esphome/components/valve/automation.h:67
- The removal of ValvePublishAction from the global valve component improves maintainability; verify that no external references to this class remain.
template<typename... Ts> class ValvePublishAction : public Action<Ts...> {
esphome/components/template/valve/init.py:94
- [nitpick] Ensure that the updated registration using cg.register_parented and cv.GenerateID aligns with the intended object lifecycle and dependency injection patterns in the automation framework.
TemplateValvePublishAction = template_ns.class_("TemplateValvePublishAction", automation.Action, cg.Parented.template(TemplateValve)
kbx81
approved these changes
May 9, 2025
juanboro
pushed a commit
to juanboro/esphome
that referenced
this pull request
May 10, 2025
Merged
Merged
sa-crespo
pushed a commit
to sa-crespo/esphome
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: