8000 [udp, syslog] fix clang tidy by tomaszduda23 · Pull Request #8755 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[udp, syslog] fix clang tidy #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

[udp, syslog] fix clang tidy #8755

merged 2 commits into from
May 12, 2025

Conversation

tomaszduda23
Copy link
Contributor

What does this implement/fix?

Fix following error

/esphome/esphome/components/syslog/esphome_syslog.h:10:50: error: use of undeclared identifier 'udp' [clang-diagnostic-error]
   10 | class Syslog : public Component, public Parented<udp::UDPComponent> {
      |                                                  ^
/esphome/esphome/components/udp/automation.h:11:87: error: unknown type name 'UDPComponent'; did you mean 'Component'? [clang-diagnostic-error]
   11 | template<typename... Ts> class UDPWriteAction : public Action<Ts...>, public Parented<UDPComponent> {
      |                                                                                       ^~~~~~~~~~~~
      |                                                                                       Component
/esphome/esphome/core/scheduler.h:11:7: note: 'Component' declared here
   11 | class Component;
      |       ^
/esphome/esphome/components/udp/packet_transport/udp_transport.h:11:80: error: unknown type name 'UDPComponent'; did you mean 'Component'? [clang-diagnostic-error]
   11 | class UDPTransport : public packet_transport::PacketTransport, public Parented<UDPComponent> {
      |                                                                                ^~~~~~~~~~~~
      |                                                                                Component
/esphome/esphome/core/scheduler.h:11:7: note: 'Component' declared here
   11 | class Component;
      |       ^
/esphome/esphome/components/udp/packet_transport/udp_transport.h:22:50: error: use of undeclared identifier 'MAX_PACKET_SIZE'; did you mean 'uart::MAX_PACKET_SIZE'? [clang-diagnostic-error]
   22 |   size_t get_max_packet_size() override { return MAX_PACKET_SIZE; }
      |                                                  ^~~~~~~~~~~~~~~
      |                                                  uart::MAX_PACKET_SIZE
/esphome/esphome/components/uart/packet_transport/uart_transport.h:20:23: note: 'uart::MAX_PACKET_SIZE' declared here
   20 | static const uint16_t MAX_PACKET_SIZE = 508;

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@tomaszduda23 tomaszduda23 requested a review from clydebarrow as a code owner May 12, 2025 20:17
@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (udp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (syslog) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link
codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.69%. Comparing base (4d8b5ed) to head (85c2a37).
Report is 2535 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8755      +/-   ##
==========================================
+ Coverage   53.70%   56.69%   +2.98%     
==========================================
  Files          50       50              
  Lines        9408     9935     +527     
  Branches     1654     1340     -314     
==========================================
+ Hits         5053     5633     +580     
+ Misses       4056     3954     -102     
- Partials      299      348      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kbx81 kbx81 merged commit facf946 into esphome:dev May 12, 2025
25 checks passed
@jesserockz jesserockz mentioned this pull request May 13, 2025
Merged
@jesserockz jesserockz mentioned this pull request May 21, 2025
Merged
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
@tomaszduda23 @sa-crespo
[udp, syslog] fix clang tidy (esphome#8755)
eb203d3
Sign up for free to join this conversation on GitHub. Already have an account? S 7193 ign in to comment
Reviewers

@kbx81 kbx81 kbx81 approved these changes

@clydebarrow clydebarrow Awaiting requested review from clydebarrow clydebarrow is a code owner

Assignees

@clydebarrow clydebarrow

Labels
integration: syslog integration: udp small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomaszduda23 @codecov-commenter @kbx81 @clydebarrow
0