Run isolation tests if there is specs folder.
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funbringer
requested changes
Apr 14, 2019
| isolation_args = [ | ||
| os.path.join(instance.work_dir, | ||
| "src/test/isolation/pg_isolation_regress"), | ||
| "--temp-instance=%s" % tmpdir, |
There was a problem hiding this comment.
Bikeshedding: I personally prefer format to %, since this is a recommended way of string formatting in 3.0+. Could you rewrite those pieces of code, please?
|
|
||
| self._regress_opts = None | ||
|
|
||
| def get_temp_config(self): |
There was a problem hiding this comment.
This function is a perfect candidate for being a property.
|
|
||
|
|
||
| class Extension: | ||
| def __init__(self, work_dir, pg_config): | ||
| self.work_dir = work_dir | ||
| self.pg_config = pg_config | ||
|
|
||
| def make(self, targets=None, options=None): | ||
| self.specs = None | ||
| specs_dir = os.path.join(work_dir, 'specs') |
There was a problem hiding this comment.
We probably shouldn't hardwire specs dir name. Maybe we could add a default-able flag to the pgxs command?
| "src/test/isolation/pg_isolation_regress"), | ||
| "--temp-instance=%s" % tmpdir, | ||
| "--inputdir=.", | ||
| "--outputdir=output_iso", |
There was a problem hiding this comment.
Needless contraction -- output_isolation?
| if target in ('check', 'installcheck') and self.specs: | ||
| print(Style.green('\n$ make isolationcheck')) | ||
|
|
||
| tmpdir = os.path.join(self.work_dir, "tmp_check_iso") |
There was a problem hiding this comment.
Maybe we should use mkdtemp to make sure that dir name is unique? Otherwise it could result in name clash when used in parallel builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.