10000 `-x` alias for `--export-all-env-vars` by dlambda · Pull Request #520 · fwdcloudsec/granted · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

-x alias for --export-all-env-vars #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

-x alias for --export-all-env-vars #520

merged 1 commit into from
Oct 19, 2023

Conversation

dlambda
Copy link
Contributor
@dlambda dlambda commented Oct 18, 2023 •
edited by shwethaumashanker
Loading

What changed?

-x alias for new --export-all-env-vars used to invoke previous (sometimes unwanted) default behaviour.

Why?

For less typing for my main use of assume

How did you test it?

Potential risks

Is patch release candidate?

Link to relevant docs PRs

#467 (comment)

8000
@chrnorm
Copy link
Contributor
chrnorm commented Oct 19, 2023

Thanks for this PR! 🙌 I think we'll also expose and document a config setting to revert the behaviour to the previous default if you prefer, as typing -z every time is just adding extra keystrokes and makes the CLI more cumbersome. I'm happy with -z, I think -x would be ideal but we already have a -ex flag to export credentials to ~/.aws/credentials so this avoids confusion with -ex.

@chrnorm chrnorm merged commit 0010e4f into fwdcloudsec:main Oct 19, 2023
@shwethaumashanker shwethaumashanker changed the title -z alias for --export-all-env-vars -x alias for --export-all-env-vars Oct 19, 2023
@dlambda
Copy link
Contributor Author
dlambda commented Oct 19, 2023

Great - thanks for this! 🤦 don't know why I messed up the branch & commit message, but did actually mean -x.

@dlambda dlambda deleted the dlamb/z_export-all-env-vars_alias branch October 19, 2023 22:34
@chrnorm
Copy link
Contributor
chrnorm commented Oct 20, 2023

🤦 oh my mistake! Given this has landed and been released we could consider eventually deprecating and eventually removing the -ex flag to prevent confusion, I don't think it's used that frequently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrnorm chrnorm chrnorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlambda @chrnorm
0