fix chrome profiles not launching if they contain slashes + automatically rename Chrome profiles #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it broke the behaviour for the --browser-profile command, for instances where the profile was created manually inside of Chrome
Eddie023
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
my/profilenow correctly open in Chrome and Chromium-based browsers(note: the automatic renaming happens the second time that Chrome is launched - on the initial launch you'll still see 'Person 2')
Also removes UserDataPath from the ChromeLauncher struct as it is unused.
Why?
How did you test it?
Potential risks
Local Statefile to adjust the IDs of your profiles.Is patch release candidate?
No - automatic renaming of Chrome profiles should be a minor change
Link to relevant docs PRs