support exec using shell script for TTY applications #549

JoshuaWilkes · 2023-11-08T04:54:44Z

Fixes #250

Uses the shell script to exec commands instead of Go, this enables TTY applications to work as expected

@todo need to implement the exec feature in the other shell scripts

Some programs like Bash would not work otherise

Exec is now dependent on the shell script, so assumego cannot be called directly to exec. Though I don't think this would be an issue for anyone

Coudl mitigate this by still supporting Go based exec as well as shell based exec

lgg42 · 2023-11-15T13:27:10Z

I'm so looking forward to this merge! In my case it is for using terragrunt apply wrapped by assume, e.g.

assume testing/RoleFoo --exec -- terraform apply

right now it is failing with

│ Error: error asking for approval: EOF

support exec using shell script

d03b05a

JoshuaWilkes changed the title ~~support exec using shell script~~ support exec using shell script for TTY applications Nov 8, 2023

fish shell

ba524dc

JoshuaWilkes requested a review from shwethaumashanker November 27, 2023 23:04

shwethaumashanker approved these changes Nov 29, 2023

View reviewed changes

shwethaumashanker merged commit 82a85a2 into main Nov 29, 2023

This was referenced Dec 28, 2023

assume --exec broken? #575

Closed

fix: assume --exec with multiple arguments/spaces #584

Merged

jhuntwork mentioned this pull request Jan 9, 2024

v0.20.6: eks get-token regression #591

Closed

Provide feedback