Add more types and reassign tag numbers in CDDL #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reassigned tag numbers to reserve some tag numbers in each (sub)group. Added these type objects in CDDL: - struct interface type - resource interface type - contract interface type - reference type - restricted type Added interface types as options to ccf-composite-type-message. Added reference and restricted types as options to inline-type. Added support for function value. Refactored CDDL to separate type objects from type value objects for readability and cleaner implemention.
turbolent
reviewed
Dec 8, 2022
turbolent
reviewed
Dec 9, 2022
Comment on lines
+597
to
+602
| ; id is a unique identifier used by CCF to associate composite/interface type information | ||
| ; with value through type-ref and type-value-ref. | ||
| id = bstr | ||
|
|
||
| ; cadence-type-id is an identifier used by Cadence to identify types. | ||
| cadence-type-id = tstr |
There was a problem hiding this comment.
Great idea to define "type aliases" 👍
turbolent
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
54AC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Added these type objects in CDDL:
Added interface types as options to ccf-composite-type-message.
Added reference and restricted types as options to inline-type.
Added support for function value.
Refactored CDDL to separate type objects from type value objects for readability and cleaner implementation.
Reassigned tag numbers to reserve some tag numbers in each (sub)group. The following groups have assigned and reserved tag numbers [128, 255]:
Unassigned tag numbers within each group are reserved for that group. In addition, there are 24 reserved tag numbers that are not associated with any existing groups [232, 255].