8000 v1.3.3 by endiliey · Pull Request #912 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

v1.3.3 #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2018
Merged

v1.3.3 #912

merged 4 commits into from
Aug 23, 2018

Conversation

endiliey
Copy link
Contributor
@endiliey endiliey commented Aug 22, 2018

Motivation

It's been quite long since the last release of Docusaurus, it's time to release a new version which is definitely more stable.

This commit is mainly created by running scripts/prerelease.sh but changelog are being updated manually.

See CHANGELOG.md for more details.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 22, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 60dc087

https://deploy-preview-912--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor
docusaurus-bot commented Aug 22, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 2515087

https://deploy-preview-912--docusaurus-preview.netlify.com

Copy link
Contributor
@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endiliey Thank you for doing this! I agree, it's been a while and now time to release again 👍

Do we need to update package-lock.json and yarn.lock for this release? Step 3 in the publish instructions

I know at some point we were thinking of removing one or both of those files, but we haven't done that yet. So I think we should keep them up to date.

@endiliey
Copy link
8000 Contributor Author
endiliey commented Aug 22, 2018

@JoelMarcey done. I missed that ⭕

Copy link
Contributor
@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit!

I will publish the npm package once this is landed.

@endiliey endiliey merged commit 2fa67bb into facebook:master Aug 23, 2018
@endiliey endiliey deleted the 1.3.3 branch August 23, 2018 03:48
@JoelMarcey
Copy link
Contributor

👍

I will publish to npm now. You want to move your draft GitHub release to publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0