`IoUringZeroCopyBufferPool` depends on unreleased liburing features #2420

sin-ack · 2025-04-21T12:18:26Z

Problem Definition

Folly recently added a IoUringZeroCopyBufferPool class in 70669ee. However, this class depends on definitions from a liburing version that hasn't been released yet. This is causing issues with packaging Folly.

Solution

Please add a configure check or build-time flag for a liburing version that supports zcrx.

CC @spikeh since this was part of your changes.

The text was updated successfully, but these errors were encountered:

sin-ack · 2025-04-21T12:37:29Z

Speaking of, it would be nice to have a configure flag for disabling liburing altogether. The current way Folly discovers uring support is non-configurable:

folly/folly/io/async/Liburing.h

Lines 19 to 23 in 5437705

    
           #if defined(__linux__) && __has_include(<liburing.h>) 
        
           #define FOLLY_HAS_LIBURING 1 
        
           #else 
        
           #define FOLLY_HAS_LIBURING 0 
        
           #endif

io_uring support is temporarily disabled because they depend on features that haven't even been released in liburing yet. Closes: https://bugs.gentoo.org/949607 Ref: facebook/folly#2420 Signed-off-by: sin-ack <sin-ack@protonmail.com>

io_uring support is temporarily disabled because they depend on features that haven't even been released in liburing yet. Closes: https://bugs.gentoo.org/949607 Ref: facebook/folly#2420 Signed-off-by: sin-ack <sin-ack@protonmail.com> Signed-off-by: Sam James <sam@gentoo.org>

There are three different problems being addressed here: 1. Recent Folly versions depend on liburing features that have not yet been released. 2. Folly has no build system configuration option to disable io_uring support. 3. Folly's CMake build system will unconditionally add liburing as a library to link against, which downstream Facebook libraries rely on. The third one creates an implicit dependency between Folly and liburing which means if liburing gets depcleaned or otherwise unmerged, unrelated packages will fail building. We solve this by conditionally patching out io_uring support based on USE=io-uring and having a (currently technically invalid) dependency on the yet-unreleased liburing-2.10, which will make it automagically start working once we do have that release in ::gentoo. Ref: facebook/folly#2420 Bug: https://bugs.gentoo.org/954335 Signed-off-by: sin-ack <sin-ack@protonmail.com>

There are three different problems being addressed here: 1. Recent Folly versions depend on liburing features that have not yet been released. 2. Folly has no build system configuration option to disable io_uring support. 3. Folly's CMake build system will unconditionally add liburing as a library to link against, which downstream Facebook libraries rely on. The third one creates an implicit dependency between Folly and liburing which means if liburing gets depcleaned or otherwise unmerged, other Facebook packages will fail to build. We solve this by conditionally patching out io_uring support based on USE=io-uring and having a (currently technically invalid) dependency on the yet-unreleased liburing-2.10, which will make it automagically start working once we do have that release in ::gentoo. Ref: facebook/folly#2420 Bug: https://bugs.gentoo.org/954335 Signed-off-by: sin-ack <sin-ack@protonmail.com>

There are three different problems being addressed here: 1. Recent Folly versions depend on liburing features that have not yet been released. 2. Folly has no build system configuration option to disable io_uring support. 3. Folly's CMake build system will unconditionally add liburing as a library to link against, which downstream Facebook libraries rely on. The third one creates an implicit dependency between Folly and liburing which means if liburing gets depcleaned or otherwise unmerged, other Facebook packages will fail to build. We solve this by conditionally patching out io_uring support based on USE=io-uring and having a (currently technically invalid) dependency on the yet-unreleased liburing-2.10, which will make it automagically start working once we do have that release in ::gentoo. Ref: facebook/folly#2420 Bug: https://bugs.gentoo.org/954335 Signed-off-by: sin-ack <sin-ack@protonmail.com> Part-of: #41734 Signed-off-by: Sam James <sam@gentoo.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`IoUringZeroCopyBufferPool` depends on unreleased liburing features #2420

`IoUringZeroCopyBufferPool` depends on unreleased liburing features #2420

IoUringZeroCopyBufferPool depends on unreleased liburing features #2420

IoUringZeroCopyBufferPool depends on unreleased liburing features #2420

Comments

Problem Definition

Solution

`IoUringZeroCopyBufferPool` depends on unreleased liburing features #2420

`IoUringZeroCopyBufferPool` depends on unreleased liburing features #2420