Vectorize CompactProtocol write on aa 8000 rch64 #9605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
77db092 to
d7f7ee8
Compare
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 23, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 23, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
d7f7ee8 to
50cfaaa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 23, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
50cfaaa to
b3c3c15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
b3c3c15 to
2511a93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
2511a93 to
1ac36e7
Compare
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
1ac36e7 to
eea7858
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Perf 8000 ormance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 8.19us 122.04K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
eea7858 to
44b57d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 7.18us 139.31K CompactProtocol_write_BigListInt 9.19us 108.81K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
44b57d1 to
7349b9d
Compare
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 24, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 28, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 28, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
47f128c to
428c0f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
428c0f1 to
39ad5dd
Compare
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
|
This pull request was exported from Phabricator. Differential Revision: D72810122 |
39ad5dd to
80b15a6
Compare
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
Apr 30, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 5, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
May 5, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 5, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
May 5, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 5, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 9, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 9, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
May 9, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122 Reviewed By: vitaut
Nicoshev
added a commit
to Nicoshev/hhvm
that referenced
this pull request
May 12, 2025
Summary: Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Reviewed By: vitaut Differential Revision: D72810122
Nicoshev
pushed a commit
to Nicoshev/hhvm
that referenced
this pull request
May 12, 2025
Summary: Pull Request resolved: facebook#9605 Vectorize CompactProtocol's list writing on aarch64. Maybe new code should be placed in a different file instead. Performance gains varies by type: before: CompactProtocol_write_SmallListInt 38.38ns 26.05M CompactProtocol_write_BigListByte 18.40us 54.33K CompactProtocol_write_BigListShort 19.30us 51.82K CompactProtocol_write_BigListInt 19.96us 50.11K CompactProtocol_write_BigListBigInt 26.54us 37.68K CompactProtocol_write_BigListFloat 18.54us 53.92K CompactProtocol_write_BigListDouble 18.79us 53.22K after: CompactProtocol_write_SmallListInt 31.65ns 31.60M CompactProtocol_write_BigListByte 223.77ns 4.47M CompactProtocol_write_BigListShort 6.58us 152.07K CompactProtocol_write_BigListInt 8.26us 121.06K CompactProtocol_write_BigListBigInt 11.40us 87.73K CompactProtocol_write_BigListFloat 830.74ns 1.20M CompactProtocol_write_BigListDouble 1.55us 645.79K Differential Revision: D72810122 Reviewed By: vitaut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Vectorize CompactProtocol's list writing on aarch64.
Maybe new code should be placed in a different file instead.
Performance gains varies by type:
before:
CompactProtocol_write_SmallListInt 38.38ns 26.05M
CompactProtocol_write_BigListByte 18.40us 54.33K
CompactProtocol_write_BigListShort 19.30us 51.82K
CompactProtocol_write_BigListInt 19.96us 50.11K
CompactProtocol_write_BigListBigInt 26.54us 37.68K
CompactProtocol_write_BigListFloat 18.54us 53.92K
CompactProtocol_write_BigListDouble 18.79us 53.22K
after:
CompactProtocol_write_SmallListInt 31.65ns 31.60M
CompactProtocol_write_BigListByte 223.77ns 4.47M
CompactProtocol_write_BigListShort 8.19us 122.04K
CompactProtocol_write_BigListInt 9.19us 108.81K
CompactProtocol_write_BigListBigInt 11.40us 87.73K
CompactProtocol_write_BigListFloat 830.74ns 1.20M
CompactProtocol_write_BigListDouble 1.55us 645.79K
Differential Revision: D72810122