Warn if you pass a hidden prop to Activity #32916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d411a31 to
2911147
Compare
rickhanlonii
approved these changes
Apr 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
Since `hidden` is a prop on arbitrary DOM elements it's a common mistake to think that it would also work that way on `<Activity>` but it doesn't. In fact, we even had this mistakes in our own tests. Maybe there's an argument that we should actually just support it but we also have more modes planned. So this adds a warning. It should also already be covered by TypeScript. DiffTrain build for [539bbdb](539bbdb)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
Since `hidden` is a prop on arbitrary DOM elements it's a common mistake to think that it would also work that way on `<Activity>` but it doesn't. In fact, we even had this mistakes in our own tests. Maybe there's an argument that we should actually just support it but we also have more modes planned. So this adds a warning. It should also already be covered by TypeScript. DiffTrain build for [539bbdb](539bbdb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
hiddenis a prop on arbitrary DOM elements it's a common mistake to think that it would also work that way on<Activity>but it doesn't. In fact, we even had this mistakes in our own tests.Maybe there's an argument that we should actually just support it but we also have more modes planned.
So this adds a warning. It should also already be covered by TypeScript.