8000 Cleanup disableDefaultPropsExceptForClasses flag by kassens · Pull Request #33648 · facebook/react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cleanup disableDefaultPropsExceptForClasses flag #33648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup disableDefaultPropsExceptForClasses flag #33648

wants to merge 1 commit into from
+18 −1,023

Conversation

kassens
Copy link
Member
@kassens kassens commented Jun 25, 2025 •
edited
Loading

No description provided.

8000

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 25, 2025
@kassens kassens requested a review from rickhanlonii June 25, 2025 23:03
@react-sizebot
Copy link
react-sizebot commented Jun 25, 2025 •
edited
Loading

Comparing: 9406162...9b4b85a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.79 kB 114.79 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 672.93 kB = 118.78 kB 118.42 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 663.36 kB = 117.20 kB 116.78 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 12.89 kB 12.51 kB = 3.52 kB 3.43 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 12.89 kB 12.51 kB = 3.52 kB 3.43 kB
facebook-www/React-dev.classic.js = 54.10 kB 52.44 kB = 12.06 kB 11.70 kB
facebook-www/React-dev.modern.js = 54.10 kB 52.44 kB = 12.06 kB 11.70 kB
facebook-www/React-profiling.classic.js = 21.16 kB 20.47 kB = 5.40 kB 5.27 kB
facebook-www/React-profiling.modern.js = 21.16 kB 20.47 kB = 5.40 kB 5.27 kB
facebook-www/React-prod.classic.js = 20.73 kB 20.04 kB = 5.32 kB 5.19 kB
facebook-www/React-prod.modern.js = 20.73 kB 20.04 kB = 5.32 kB 5.18 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOM-profiling.classic.js = 745.07 kB 743.22 kB = 128.14 kB 127.78 kB
facebook-www/ReactDOM-profiling.modern.js = 737.03 kB 735.12 kB = 126.85 kB 126.47 kB
facebook-www/ReactDOMTesting-prod.classic.js = 689.21 kB 687.34 kB = 122.37 kB 122.02 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 672.93 kB = 118.78 kB 118.42 kB
facebook-www/ReactDOMTesting-prod.modern.js = 679.70 kB 677.76 kB = 120.84 kB 120.43 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 663.36 kB = 117.20 kB 116.78 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 261.31 kB 260.33 kB = 47.86 kB 47.65 kB
facebook-www/ReactDOMServer-prod.classic.js = 254.59 kB 253.61 kB = 45.54 kB 45.33 kB
facebook-www/ReactDOMServer-prod.modern.js = 252.23 kB 251.25 kB = 45.20 kB 44.99 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,244.10 kB 1,238.82 kB = 206.61 kB 205.81 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,234.96 kB 1,229.65 kB = 204.91 kB 204.08 kB
facebook-www/ReactDOM-dev.classic.js = 1,227.56 kB 1,222.29 kB = 202.92 kB 202.12 kB
facebook-www/ReactDOM-dev.modern.js = 1,218.42 kB 1,213.12 kB = 201.19 kB 200.38 kB
facebook-www/ReactReconciler-prod.classic.js = 509.28 kB 506.97 kB = 81.25 kB 80.87 kB
facebook-www/ReactDOMServer-dev.classic.js = 411.67 kB 409.78 kB = 73.99 kB 73.66 kB
facebook-www/ReactDOMServer-dev.modern.js = 408.23 kB 406.35 kB = 73.43 kB 73.07 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 406.42 kB 404.54 kB = 72.90 kB 72.55 kB
facebook-www/ReactReconciler-prod.modern.js = 499.19 kB 496.81 kB = 79.70 kB 79.33 kB
facebook-www/ReactART-prod.classic.js = 386.29 kB 384.06 kB = 64.75 kB 64.35 kB
facebook-www/ReactART-prod.modern.js = 376.50 kB 374.22 kB = 63.12 kB 62.74 kB
test_utils/ReactAllWarnings.js = 67.03 kB 66.57 kB = 16.83 kB 16.72 kB
facebook-www/ReactART-dev.classic.js = 731.66 kB 726.15 kB = 113.92 kB 113.26 kB
facebook-www/ReactART-dev.modern.js = 722.16 kB 716.63 kB = 112.17 kB 111.44 kB
facebook-www/ReactReconciler-dev.classic.js = 848.15 kB 841.01 kB = 131.75 kB 130.34 kB
facebook-www/ReactReconciler-dev.modern.js = 838.95 kB 831.78 kB = 129.96 kB 128.54 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 12.89 kB 12.51 kB = 3.52 kB 3.43 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 12.89 kB 12.51 kB = 3.52 kB 3.43 kB
facebook-www/React-dev.classic.js = 54.10 kB 52.44 kB = 12.06 kB 11.70 kB
facebook-www/React-dev.modern.js = 54.10 kB 52.44 kB = 12.06 kB 11.70 kB
facebook-www/React-profiling.classic.js = 21.16 kB 20.47 kB = 5.40 kB 5.27 kB
facebook-www/React-profiling.modern.js = 21.16 kB 20.47 kB = 5.40 kB 5.27 kB
facebook-www/React-prod.classic.js = 20.73 kB 20.04 kB = 5.32 kB 5.19 kB
facebook-www/React-prod.modern.js = 20.73 kB 20.04 kB = 5.32 kB 5.18 kB

Generated by 🚫 dangerJS against 9b4b85a

@kassens kassens force-pushed the pr33648 branch 2 times, most recently from 3804a27 to e8fb78b Compare June 25, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kassens @react-sizebot @facebook-github-bot
0