Root import types from react-native in ReactNativeTypes #33063
Merged
+34
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 0ca8420...1b8d205 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates deep import from react-native to the root import. The motivation behind this is that the newly introduced package exports in react native are more strict, and this import breaks type resolution for
ReactNativePrivateInterface.After adding
HostInstance,PublicTextInstance, andPublicRootInstanceto thereact-nativemodule, CIs failed due to different opaque types inreact-nativeandReactNativePrivateInterface. Moving their declarations to the global scope fixed the issue. It is not entirely possible to migratereact-native-rendererto root imports, as not all used identifiers are root exported inreact-native.Imported
reacttypes are changed to be used under theReactnamespace. This is required for Flow tooling to translate them into TypeScript equivalents correctly.How did you test this change?
Signals, react-native main