[eslint-plugin-react-hooks] updates for component syntax #33089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db00b21 to
72d9402
Compare
poteto
reviewed
May 2, 2025
| return false; | ||
|
|
||
| case 'FunctionDeclaration': | ||
| case 'ComponentDeclaration': |
There was a problem hiding this comment.
Since the changes to this package are trivial, what do you think about patching it instead? It wouldn't conflict that often and if it did it would be easy to fix.
There was a problem hiding this comment.
This is the patched version, not sure I follow.
There was a problem hiding this comment.
I mean as a git patch via https://www.npmjs.com/package/patch-package
There was a problem hiding this comment.
it's in node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js etc
There was a problem hiding this comment.
I'll leave that as a followup for someone who wants to figure this out. Not sure adding more hacks on top of the already complicated build infra is actually better than a few forked files.
packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js
Outdated
Show resolved
Hide resolved
Adds support for Flow's component and hook syntax. [docs](https://flow.org/en/docs/react/component-syntax/)
github-actions bot
pushed a commit
that referenced
this pull request
May 2, 2025
Adds support for Flow's component and hook syntax. [docs](https://flow.org/en/docs/react/component-syntax/) DiffTrain build for [4c4a57c](4c4a57c)
jorge-cab
pushed a commit
that referenced
this pull request
May 2, 2025
Adds support for Flow's component and hook syntax. [docs](https://flow.org/en/docs/react/component-syntax/)
This was referenced May 5, 2025
This was referenced May 12, 2025
This was referenced May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Flow's component and hook syntax. docs