[Fizz] Always load the external runtime if one is provided #33091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 0ed6ceb...db624e8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
bf4170e to
742f8bc
Compare
742f8bc to
fe7e9b2
Compare
gnoff
approved these changes
May 1, 2025
Comment on lines
704
to
706
| (gate(flags => flags.shouldUseFizzExternalRuntime) | ||
| ? '<script src="react-dom-bindings/src/server/ReactDOMServerExternalRuntime.js" async=""></script>' | ||
| : '') + |
There was a problem hiding this comment.
script src should be react-dom/unstable_server-external-runtime
fe7e9b2 to
8a4c659
Compare
8a4c659 to
0f2e1e4
Compare
0f2e1e4 to
db624e8
Compare
|
One thing we could do is maybe make it conditional if there are no eligible Suspense boundaries rendered. Which if if you set |
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2025
Because we now decided whether to outline in the flushing phase, when we're writing the preamble we don't yet know if we will make that decision so we don't know if it's safe to omit the external runtime. However, if you are providing an external runtime it's probably a pretty safe bet you're streaming something dynamically that's likely to need it so we can always include it. The main thing is that this makes it hard to test it because it affects our tests in ways it wouldn't otherwise so we have to add a bunch of conditions. DiffTrain build for [f739642](f739642)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 2, 2025
…33091) Because we now decided whether to outline in the flushing phase, when we're writing the preamble we don't yet know if we will make that decision so we don't know if it's safe to omit the external runtime. However, if you are providing an external runtime it's probably a pretty safe bet you're streaming something dynamically that's likely to need it so we can always include it. The main thing is that this makes it hard to test it because it affects our tests in ways it wouldn't otherwise so we have to add a bunch of conditions. DiffTrain build for [f739642](facebook@f739642)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 2, 2025
…33091) Because we now decided whether to outline in the flushing phase, when we're writing the preamble we don't yet know if we will make that decision so we don't know if it's safe to omit the external runtime. However, if you are providing an external runtime it's probably a pretty safe bet you're streaming something dynamically that's likely to need it so we can always include it. The main thing is that this makes it hard to test it because it affects our tests in ways it wouldn't otherwise so we have to add a bunch of conditions. DiffTrain build for [f739642](facebook@f739642)
This was referenced May 2, 2025
This was referenced May 13, 2025
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we now decided whether to outline in the flushing phase, when we're writing the preamble we don't yet know if we will make that decision so we don't know if it's safe to omit the external runtime.
However, if you are providing an external runtime it's probably a pretty safe bet you're streaming something dynamically that's likely to need it so we can always include it.
The main thing is that this makes it hard to test it because it affects our tests in ways it wouldn't otherwise so we have to add a bunch of conditions.